Fix warning when despawning sleeping bodies #924
Merged
+69
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Bug
Jondolf
added
the
M-Migration-Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #922.
If you try to despawn a sleeping body, you might occasionally get a warning like "Tried to wake body 3127v2 that does not exist". This is because we have a hook that applies the
WakeBodycommand whenSleepingis removed, and that command emits a warning for non-existent bodies.Solution
Use proper error handling for the command, and use
queue_silencedin the hook.Testing
Despawned some sleeping bodies.